Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run format job in master branch #33896

Merged
merged 3 commits into from
Mar 21, 2020
Merged

Only run format job in master branch #33896

merged 3 commits into from
Mar 21, 2020

Conversation

BruceForstall
Copy link
Member

@BruceForstall BruceForstall commented Mar 20, 2020 •
edited
Loading

Don't run it in servicing branches, since it depends
on an unversioned jitutils repo.

@BruceForstall
Only run format job in master branch
a9c6578 
Don't run it in servicing branches, since it depends
on an unversions `jitutils` repo.
@BruceForstall BruceForstall mentioned this pull request Mar 20, 2020
Closed
@jkotas
Copy link
Member

jkotas commented Mar 21, 2020

Failures are known issue:

Process terminated. Assertion failed.
Should've been checked by caller.
   at System.Text.ASCIIUtility.GetIndexOfFirstNonAsciiByte_Sse2(Byte* pBuffer, UInt64 bufferLength)

@jkotas jkotas merged commit 7c7e9ec into dotnet:master Mar 21, 2020
ViktorHofer
ViktorHofer approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredpar jaredpar mentioned this pull request Mar 21, 2020
Closed
@BruceForstall BruceForstall deleted the FormatJobOnlyForMaster branch March 21, 2020 17:36
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jashook jashook jashook approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@BruceForstall @jkotas @jashook @ViktorHofer @safern @Dotnet-GitSync-Bot